Simplify setup for monorepos

[sibelius]

Describe the Feature

On iOS, you need to set PROJECT_ROOT in order to make CLI work in a monorepo. On Android, same set of configuration is required.

Possible Implementations

• Get rid of PROJECT_ROOT on iOS because it's not needed anymore
• Figure out strategy for Android.

Related Issues

related to #865 #656

[sibelius]

this is my error when building

Error: Cannot find module '/app/packages/app/node_modules/react-native/cli.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:794:15)
    at Function.Module._load (internal/modules/cjs/loader.js:687:27)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1025:10)
    at internal/main/run_main_module.js:17:11 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

as it searches for react-native in the wron glocation

[sibelius]

I've got this working like this

project.ext.react = [
    entryFile: "index.js",
    bundleInStaging: true,
    devDisabledInStaging: true,
    bundleInAlpha: true,
    devDisabledInAlpha: true,
    enableHermes: false,  // clean and rebuild if changing
+    root: "../../../../"
]

modifying root path on app/build.gradle

but this raised another issue

error Invalid platform "android" selected.
info Available platforms are: "native". If you are trying to bundle for an out-of-tree platform, it may not be installed.

it only shows the android command inside react-native packages inside our monorepo (like here https://github.com/entria/entria-fullstack/tree/master/packages/app), but fails on root

what is the proper solution for this?

[sibelius]

fixed android like this

project.ext.react = [
   cliPath: "../../node_modules/react-native/cli.js",
]

[sibelius]

ios also need this

export NODE_BINARY=node
export PROJECT_ROOT="$PROJECT_DIR/.."

../../../node_modules/react-native/scripts/react-native-xcode.sh

[grabbou]

Yeah, in my experience, this is the major root cause for all of the monorepo issues that a lot of people are facing these days.

Any idea how we could plug into it? Setting dynamically variables?

[sibelius]

this is a hard one, maybe a monorepo documentation guide could be good enough

[yuzhakovvv]

fixed android like this

project.ext.react = [
   cliPath: "../../node_modules/react-native/cli.js",
]

In my case it was

project.ext.react = [
    ...
    entryFile: "index.js",
    cliPath: "../node_modules/react-native/cli.js",
]

Because project structure is:

node_modules/
- react-native/
mobile/
- node_modules/
- index.js
shared/
web/

[grabbou]

@sibelius, following up to my discussions #656 (comment), we should be able to safely remove PROJECT_ROOT.

In theory, we always want it to be ios/.. and even if it ends up being deeper in the hierarchy, CLI knows what to do.

[grabbou]

If you look at the details of the commit that introduced this change - facebook/react-native@9ccde37, I believe its assumptions are no longer true and we can get rid of it.

Waiting for Janic to get back to me whether this is right and I believe we can follow up with a PR. This particular change shouldn't require anything on the CLI side.

[grabbou]

The ideal for me is this on iOS, regardless of your step

export NODE_BINARY=node
../../../node_modules/react-native/scripts/react-native-xcode.sh