fix: pass projectRoot path to doctors fixers#1669
Closed
adamTrz wants to merge 2 commits intoreact-native-community:mainfrom
Closed
fix: pass projectRoot path to doctors fixers#1669adamTrz wants to merge 2 commits intoreact-native-community:mainfrom
adamTrz wants to merge 2 commits intoreact-native-community:mainfrom
Conversation
Collaborator
Author
|
Just had a thought that this PR will add additional complexity instead of simplify things in the code and is a bit artificial. Let's leave things as is, and if any doctor command will require projectRoot it will just fetch it like it was done before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pass
projectRootas an argument both todoctor'sgetDiagnosticsandrunAutomaticFixmethods.Fixes: #1588
Test Plan:
doctorshould still work.