Skip to content

Conversation

@MateWW
Copy link
Contributor

@MateWW MateWW commented Nov 9, 2022

Summary:

As a follow-up to #1739 I've created build-ios command.
Besides that, I've refactored run-ios to share parts used in both commands

Test Plan:

  • crate app with react-native init
  • link CLI
  • run yarn react-native build-ios

docs/commands.md Outdated

#### Options

#### `--mode <release|debug>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use --configuration instead of --mode, because --mode doesn't exist.

Suggested change
#### `--mode <release|debug>`
#### `--configuration <release|debug>`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually that was kinda requested feature to unify naming convention when building / running the app with custom params for both platforms.
You can read a bit more here: #1128 and here: #179

@MateWW MateWW requested review from adamTrz and szymonrybczak and removed request for adamTrz, szymonrybczak and thymikee November 16, 2022 15:30
@adamTrz adamTrz mentioned this pull request Nov 17, 2022
5 tasks
@cortinico
Copy link
Member

cc @cipolleschi if you want to have a look here

@MateWW MateWW requested review from adamTrz and removed request for adamTrz December 5, 2022 11:44
@MateWW MateWW requested review from adamTrz and szymonrybczak and removed request for szymonrybczak December 5, 2022 11:44
@github-actions github-actions bot added docs Documentation change feature labels Jan 24, 2023
@adamTrz adamTrz merged commit e932dd6 into react-native-community:main Jan 25, 2023
@thymikee thymikee changed the title feat: build-ios command feat: add build-ios command Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation change feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants