Skip to content

chore: Remove fs-extra reference from cli-plugin-metro #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Jun 16, 2023
Merged

chore: Remove fs-extra reference from cli-plugin-metro #1971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions packages/cli-plugin-metro/src/commands/bundle/assetCatalogIOS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import path from 'path';
import fs from 'fs-extra';
import fs from 'fs';
import type {AssetData} from 'metro';
import assetPathUtils from './assetPathUtils';

Expand All @@ -16,7 +16,7 @@ export function cleanAssetCatalog(catalogDir: string): void {
.readdirSync(catalogDir)
.filter((file) => file.endsWith('.imageset'));
for (const file of files) {
fs.removeSync(path.join(catalogDir, file));
fs.rmSync(path.join(catalogDir, file));
}
}

Expand Down Expand Up @@ -49,22 +49,25 @@ export function isCatalogAsset(asset: AssetData): boolean {
}

export function writeImageSet(imageSet: ImageSet): void {
fs.mkdirsSync(imageSet.basePath);
fs.mkdirSync(imageSet.basePath);
Copy link
Collaborator

@robhogan robhogan Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huntie This should have { recursive: true } to be equivalent to mkdirs.


for (const file of imageSet.files) {
const dest = path.join(imageSet.basePath, file.name);
fs.copyFileSync(file.src, dest);
}

fs.writeJSONSync(path.join(imageSet.basePath, 'Contents.json'), {
images: imageSet.files.map((file) => ({
filename: file.name,
idiom: 'universal',
scale: `${file.scale}x`,
})),
info: {
author: 'xcode',
version: 1,
},
});
fs.writeFileSync(
path.join(imageSet.basePath, 'Contents.json'),
JSON.stringify({
images: imageSet.files.map((file) => ({
filename: file.name,
idiom: 'universal',
scale: `${file.scale}x`,
})),
info: {
author: 'xcode',
version: 1,
},
}),
);
}