Skip to content

Rename /status project root header #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Aug 18, 2023
Merged

Rename /status project root header #2060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/cli-server-api/src/__tests__/statusPageMiddleware.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ describe('statusPageMiddleware', () => {
statusPageMiddleware(mockReq, res);

// We're strictly checking response here, because React Native is strongly depending on this response. Changing the response might be a breaking change.
expect(res.setHeader).toHaveBeenCalledWith('Project-Root', '/mocked/path');
expect(res.setHeader).toHaveBeenCalledWith(
'X-React-Native-Project-Root',
'/mocked/path',
);
expect(res.end).toHaveBeenCalledWith('packager-status:running');
});
});
2 changes: 1 addition & 1 deletion packages/cli-server-api/src/statusPageMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ export default function statusPageMiddleware(
_req: http.IncomingMessage,
res: http.ServerResponse,
) {
res.setHeader('Project-Root', process.cwd());
res.setHeader('X-React-Native-Project-Root', process.cwd());
res.end('packager-status:running');
}
2 changes: 1 addition & 1 deletion packages/cli-tools/src/isPackagerRunning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ async function isPackagerRunning(
if (data === 'packager-status:running') {
return {
status: 'running',
root: headers.get('Project-Root') ?? '',
root: headers.get('X-React-Native-Project-Root') ?? '',
};
}
} catch (_error) {
Expand Down