Skip to content

fix: do not ask for port change when --no-packager provided #2128

Merged
thymikee merged 3 commits intomainfrom
fix/do-not-ask-for-port-change-when-no-packager
Oct 27, 2023
Merged

fix: do not ask for port change when --no-packager provided #2128
thymikee merged 3 commits intomainfrom
fix/do-not-ask-for-port-change-when-no-packager

Conversation

@szymonrybczak
Copy link
Copy Markdown
Collaborator

Summary:

Hides prompt when port is busy when provided --no-packager flag.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Start packager in other app on 8081 port
  3. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios --no-packager

Shouldn't prompt for port change.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak
Copy link
Copy Markdown
Collaborator Author

cc. @huntie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants