feat: add link-assets command #2276
Conversation
|
Started code review and left some comments, gonna continue reviewing tomorrow :) |
This reverts commit 2fe7b95.
|
Thanks @TMisiukiewicz I will make these adjustments! |
|
Ok I got a look at this PR and I have doubts exposing it to users. This commands works in a legacy way of manually changing Xcode and Gradle files – even asking users to do so. I hoped it would leverage the autolinking mechanism so that DX is nicer. Please take a look at how rnx-kit team achieves that: microsoft/react-native-test-app#1828 in less than 200 lines of code. If the time is pressure, I'm ok with merging that into the repository, but I'm not ok exposing this command to every user. It will add a lot of size to the package that's already pretty big. Therefore I'd suggest to document how one could use this package ( |
|
Waiting for CI to be green and gonna merge it. Thanks so much for porting this code @fabioh8010, it's a great amount of effort to keep this library afloat and should be a good ground to iterate for a better, autolink-enabled solution in the future 👍🏼 |
|
@thymikee Could you run the E2E workflow tests again? Thanks! |
|
why do I need to approve the pipeline twice, geez GitHub cmon |
|
The CI passed 🎉 |

Summary:
This PR aims to implement a feature to help users link their assets in their projects in an automated and efficient way. This PR will basically bring functionality from react-native-asset package + this new feature to link Android assets using XML Fonts. Due to the lack of maintenance in the original repo, we've published a new version under CK organisation here, but after some discussions we decided to bring the feature to the CLI.
Relevant links/discussions in chronological order:
Tasks
Test Plan:
TODO
Checklist