Skip to content

Support versioned/tagged shorthand templates #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Taym95 wants to merge 1 commit into from
Closed

Support versioned/tagged shorthand templates #483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/cli/src/commands/init/templateName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,20 @@ async function tryTemplateShorthand(templateName: string) {
return templateName;
}
try {
const reactNativeTemplatePackage = `react-native-template-${templateName}`;
const response = await fetch(
`https://registry.yarnpkg.com/${reactNativeTemplatePackage}/latest`,
);
const nameTagArray = templateName.split('@');
const name = nameTagArray[0];
const tag = nameTagArray[1];
Copy link
Member

@thymikee thymikee Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's assign a default value here, so we can avoid branching:

Suggested change
const tag = nameTagArray[1];
const tag = nameTagArray[1] || 'latest';

const reactNativeTemplatePackage = `react-native-template-${name}`;
var response;
Copy link
Member

@thymikee thymikee Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var response;
const response = await fetch(
`https://registry.yarnpkg.com/${reactNativeTemplatePackage}/${tag}`,
);

if (tag) {
response = await fetch(
`https://registry.yarnpkg.com/${reactNativeTemplatePackage}/${tag}`,
);
} else {
response = await fetch(
`https://registry.yarnpkg.com/${reactNativeTemplatePackage}/latest`,
);
}

if (JSON.parse(response).name) {
return reactNativeTemplatePackage;
Expand Down