Extend recommended React Native TSConfig base#281
Merged
radko93 merged 8 commits intoreact-native-community:mainfrom Jun 30, 2022
leotm:patch-1
Merged
Extend recommended React Native TSConfig base#281radko93 merged 8 commits intoreact-native-community:mainfrom leotm:patch-1
radko93 merged 8 commits intoreact-native-community:mainfrom
leotm:patch-1
Conversation
Collaborator
|
Hi, can you update this branch with master and see if it runs the lint action? |
Contributor
Author
|
sure ^ how do you feel about what @orta mentioned btw |
Contributor
Author
Member
|
Yeah, IMO, you should present an empty tsconfig if you're going with the |
Contributor
Author
|
from messing around earlier but sure an empty tsconfig w |
Contributor
Author
Contributor
Author
|
and happy to remove any overrides like es2019 once merged in |
- merged in tsconfig/bases#116 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended
- merged in tsconfig/bases#118 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended
radko93
approved these changes
Jun 30, 2022
Collaborator
|
LGTM, great work! |
This was referenced Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Context
To keep our recommended React Native TSConfig base as the source
yarn set version classicts --initcomment boilerplate (can still remove further)es2019overrideforceConsistentCasingInFileNamesoverrideHave a think if skipLibCheck should be recommended for React Native, we do in few others
Remove duplicate rule overridesKeep duplicate rule overrides for visibility