Upcoming v0.64.2 cherrypicks discussion

[kelset]

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.1 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

PRs to merge:

• fix: update to @jest/create-cache-key-function@27 facebook/react-native#30637
• fix: codegen - project paths with spaces facebook/react-native#31141 -> facebook/react-native@b2e2f43
• Add mocks to fix: handleException is not a function (#29849) facebook/react-native#30027
• Fix cli bundle platform for Mac Catalyst in react-native-xcode.sh facebook/react-native#31062

Ready for cherry-pick:

• [Fix] Android: font-family is not apply when secureTextEntry is true facebook/react-native#30164 -> facebook/react-native@00d9dea
• [iOS] Use relative paths for pod spec to keep checksum stable facebook/react-native#31195 this was closed mentioning this as solution -> facebook/react-native@bdfe2a5
• facebook/react-native@310a6bc
• facebook/react-native@3399896
• facebook/react-native@0e9296b
• facebook/react-native@291cc95
• facebook/react-native@b0e8c1e

Issues to resolve:

• Unable to find JSIModule for class UIManager facebook/react-native#31245
• [0.64.0] archive fails for release due to invalid check for custom ENTRY_FILE facebook/react-native#31282
• 0.64 stable new template fails when using use_frameworks! facebook/react-native#31149

[myckhel]

i feel the previous discussion #221 has less meaning.
after all only 5 commits were pushed to the v0.64.1 stack.

[kelset]

@myckhel the reason why 0.64.1 was so small is that we wanted to quickly address the Xcode 12.5 problem which was a real blocker for a lot of developers.

[mikehardy]

Issue facebook/react-native#31245 just got a resolution!
Please please cherry pick facebook/react-native@b0e8c1e and thank you :-)

[danilobuerger]

@kelset the issue that @mikehardy mentioned seems to be a pretty big blocker too judging by the amount of emojis the issue got in that short time frame. Maybe its worth doing a speedy release here too?

[haralddoderer]

@kelset the issue that @mikehardy mentioned seems to be a pretty big blocker too judging by the amount of emojis the issue got in that short time frame. Maybe its worth doing a speedy release here too?

It would be nice if there was some kind of patch or a workaround available until we get the next release. I also still use 0.64.1 and I am afraid that lot's of dependencies then might break on updating. A backport to 0.64.1 would also be welcomed.

@kelset I just want to say thank you for all the hard work you invest. Hope you can help us here.

[sanduluca]

Please cherry pick facebook/react-native@00d9dea
This is very annoying to see that your styles are not working properly.
Thank you for your work. ❤🔥

[riccardonucleare]

Please cherry pick: facebook/react-native#31457
Quite an important issue to add.

[mikehardy]

@riccardonucleare that issue is not closed, there is no commit landed on master, it is not a valid cherry-pick request. From the top of this issue

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.1 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

I think best course is to focus effort on getting it merged then it's time to head here and request a pick

[shrmaky]

OS - Mac Big Sur (11.2.3 (20D91))
Processor - 2.3 GHz 8-Core Intel Core i9

What i tried to solve issue?

1. Tried upgrading to 64.1
2. Cleaned up everything node_modules, pods, derived data
3. I also deleted Flipper Default options pods, it reached at the end and thrown the error that this pod not found. I think culprit is mainly RCT-Folly.default-Futures

Terminal Error: when we run npx react-native run-ios

The following build commands failed:
        CompileC /Users/mac/Library/Developer/Xcode/DerivedData/mobilebuyerapp-fcfjbndwsgiwnbdtzkwidfuyukob/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.default-Futures.build/Objects-normal/x86_64/DistributedMutex.o /Users/mac/workspace/mobile-buyer-app/ios/Pods/RCT-Folly/folly/synchronization/DistributedMutex.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

[beetlebum]

OS - Mac Big Sur (11.2.3 (20D91))
Processor - 2.3 GHz 8-Core Intel Core i9

What i tried to solve issue?

1. Tried upgrading to 64.1
2. Cleaned up everything node_modules, pods, derived data
3. I also deleted Flipper Default options pods, it reached at the end and thrown the error that this pod not found. I think culprit is mainly RCT-Folly.default-Futures

Terminal Error: when we run npx react-native run-ios

The following build commands failed:
        CompileC /Users/mac/Library/Developer/Xcode/DerivedData/mobilebuyerapp-fcfjbndwsgiwnbdtzkwidfuyukob/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.default-Futures.build/Objects-normal/x86_64/DistributedMutex.o /Users/mac/workspace/mobile-buyer-app/ios/Pods/RCT-Folly/folly/synchronization/DistributedMutex.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

@shrmaky in your Podfile, replace flipper_pod_install with react_native_post_install

[AstroCorp]

merge this fix please :/

facebook/react-native#29099