Skip to content

Conversation

@huntie
Copy link
Collaborator

@huntie huntie commented Sep 27, 2024

Summary

This is now simpler, and more closely aligned with Expo's template. Also switch it() to test().

Changelog:
[General][Added] - Add @types/jest dev dependency, simplify test example

Test Plan

Apply changes to a freshly created 0.76.0-rc.2 project.

image

@types/jest automatically discovered by TypeScript, allowing us to remove the old type import
✅ Tests pass

@huntie huntie requested a review from cortinico September 27, 2024 13:25
@huntie huntie merged commit 471c419 into react-native-community:main Sep 27, 2024
@huntie huntie deleted the types-jest branch September 27, 2024 13:49
@cortinico
Copy link
Member

@huntie can we have this in 0.77 instead?

@huntie
Copy link
Collaborator Author

huntie commented Sep 27, 2024

Sure — this is main though. Let's create a 0.76-stable branch for this repo?

@cortinico
Copy link
Member

Sure — this is main though. Let's create a 0.76-stable branch for this repo?

It's already there: https://github.com/react-native-community/template/tree/0.76-stable

@huntie
Copy link
Collaborator Author

huntie commented Sep 27, 2024

Cool. I'm absolutely not suggesting this needs to be picked :)

@cortinico
Copy link
Member

Cool. I'm absolutely not suggesting this needs to be picked :)

Top 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants