Fix copyFile on Android.#392
Merged
vonovak merged 1 commit intoreact-native-documents:masterfrom Mar 8, 2021
Merged
Conversation
Member
|
thanks for the PR! |
DomiR
added a commit
to DomiR/react-native-document-picker
that referenced
this pull request
Mar 30, 2021
* upstream/master: (22 commits) 5.0.2 fix: copyTo on android to put the file in a uniquely named dir (react-native-documents#397) 5.0.1 Fix copyFile on Android. (react-native-documents#392) chore: document RN blob support 5.0.0 support only android >=5 (API 21) (react-native-documents#386) [Android][Google Drive] Download file from google drive then cache in local storage (react-native-documents#264) 4.3.0 [Windows] Implementing Folder Picker support (react-native-documents#380) Fix crash on iOS (react-native-documents#383) chore: deleted duplicate test case (react-native-documents#375) chore: change readme wording 4.2.0 iOS : add mode option (react-native-documents#345) chore: update comment for closing issues (react-native-documents#373) chore: update discussions in readme (react-native-documents#372) chore: introduce GH discussions (react-native-documents#371) chore: add issue actions (react-native-documents#369) chore: update provided file type shortcuts ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copyFilemethod is incorrect for Android (haven't checked iOS as I'm not familiar with it).InputStream.readreturns the number of bytes read, it may be that only a few bytes are read but theOutputStream.writemethod with one argument always writes the whole buffer even if only the first few bytes are set.