[iOS Google Maps] Fix update camera always animated#2446
Closed
a821246710 wants to merge 1 commit intoreact-native-maps:masterfrom
Closed
[iOS Google Maps] Fix update camera always animated#2446a821246710 wants to merge 1 commit intoreact-native-maps:masterfrom
a821246710 wants to merge 1 commit intoreact-native-maps:masterfrom
Conversation
|
Yes this is something that we noticed and needed as well. Will this be merged sometime? |
Collaborator
|
pull request merged in master thanks @a821246710 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
iOS GoogleMap update camera always animated.
fitToElements,fitToSuppliedMarkersandfitToCoordinateshasanimatedparameter but real implantation ignore this parameter, always callanimateWithCameraUpdate.How did you test this PR?
run on iOS simulator (iOS 11.4)