Skip to content

Upgrade react-native to 0.59.3#2792

Merged
rborn merged 1 commit intoreact-native-maps:masterfrom
friederbluemle:upgrade-react-native
Apr 5, 2019
Merged

Upgrade react-native to 0.59.3#2792
rborn merged 1 commit intoreact-native-maps:masterfrom
friederbluemle:upgrade-react-native

Conversation

@friederbluemle
Copy link
Contributor

Does any other open PR do the same thing?

No

What issue is this PR fixing?

This updates the react-native dependency in the example project from 0.54 to the latest version 0.59.3.

How did you test this PR?

Tested on:

  • Android Emulator
  • Android Device (Xiaomi A1)
  • iOS Simultor (iPhone X)
  • iOS Device (iPhone 8)

@rborn
Copy link
Collaborator

rborn commented Apr 5, 2019

@friederbluemle ❤️

Could you try to update travis config to node 10 maybe it builds 🤗

@friederbluemle
Copy link
Contributor Author

@rborn - Update to 8 was enough to make it pass. Please let me know if you prefer it to be set to 10 (it would be my preference too, since it's the current LTS version).

@friederbluemle
Copy link
Contributor Author

We could also set it to lts/*, as explained here: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/

@rborn
Copy link
Collaborator

rborn commented Apr 5, 2019

@friederbluemle go for it 🤗

@friederbluemle
Copy link
Contributor Author

@rborn - lts/* works well. It installs the latest long term support version (v10.15.3) 👌

@rborn rborn merged commit 00552ea into react-native-maps:master Apr 5, 2019
@friederbluemle friederbluemle deleted the upgrade-react-native branch April 5, 2019 11:29
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants