iOS Fix: Use RCTImageLoaderProtocol for ReactNative v0.61.0

[fenderface66]

Does any other open PR do the same thing?

No

(please answer here)

What issue is this PR fixing?

RCTImageLoader no longer works in iOS builds for RN>0.61.0. You need to use RCTIMageLoaderProtocol instead.
(please link the issue here)

How did you test this PR?

By successfully building the project after these changes were made.

1. Create a RN0.61.0 project
2. Link react-native-maps
3. Try to build iOS

(please answer here)

[rborn]

Hi @fenderface66 thnx for the PR, doesn't #3125 already fix this issue?

[fenderface66]

@rborn Unfortunately not because that PR still tries to import the ImageLoader which causes the build to fail:

[rborn]

@brien-crean can you please jump in and you guys make the best of both PRs? ❤️ My ObjC is less than rusty😅 so I'd need help here 🤗

[fenderface66]

@brien-crean what do you think? I'd love to get this merged soon so that I don't have to use my own fork 😄

[qyhongfan]

same issue

[brien-crean]

@rborn @fenderface66 I just tried this out. This looks great to me, thanks @fenderface66! I say merge this on top of what was already merged from mine as it fixes the missing RCTIMageLoaderProtocol from my PR

[James-E-Adams]

Looks great - This is one of the blockers for us to bump to RN0.61.x. Anything I can do to help get this out in a release? Would love to avoid vendoring react-native-maps.

Edit: As an aside, is this implementation still backwards compatible with previous RN versions?

[rborn]

@brien-crean @fenderface66 ❤️