Updates AnimatedRegion component#3744
Conversation
…more succinct, and constructor w/ common setInitialValue method for Animated.Value; ADDED: configTypes and defaultValues vars
…h useNativeDriver true
…s prop used in spring and timing methods, with coersion to false when not provided
|
@jasonmichaels I'm not sure why those files int the android directory were creating but I don't think it was from merging in master. Either way, do you mind checkout out those files? I think the only files that need to be changed are |
|
@jasonmichaels any updates here ? |
|
@jasonmichaels can you please give an update to this PR? |
|
@christopherdro I updated the PR to infer/coerce |
|
@miallo I removed the instance method, |
…and AnimatedRegionSpringConfig; REMOVED: useNativeDriver from AnimatedRegion
* CHANGED: spring and timing methods of AnimatedRegion component to be more succinct, and constructor w/ common setInitialValue method for Animated.Value; ADDED: configTypes and defaultValues vars * FIXED: linting on AnimatedRegion component * REVERTED: changes to Podfile.lock * REVERTED: changes to Podfile.lock * CHANGED: Animated.spring and Animated.timing in AnimatedRegion to both useNativeDriver true * ADDED: optional useNativeDriver to AnimatedRegion constructor as class prop used in spring and timing methods, with coersion to false when not provided * ADDED: useNativeDRiver to Region interface as optional * FIXED: typo on AnimatedRegion from useDefaultDrive to useNativeDriver * CHANGED: AnimatedRegion spring and timing methods w/ optional config.useNativeDriver * UPDATED: README, AnimatedMarkers, AnimatedViews w/ useNativeDriver notes on spring and timing * CHANGED: index.d.ts w/ useNativeDriver on AnimatedRegionTimingConfig and AnimatedRegionSpringConfig; REMOVED: useNativeDriver from AnimatedRegion * REMOVED: files added during build testing in OS dirs Co-authored-by: Jason White <jasonwhite@Jasons-MacBook-Pro.local>
This PR doesn't directly address any issues; rather, it's more of a cleanup PR.
Changes
springandtimingmethods of theAnimatedRegioncomponentlatitude,longitude,latitudeDelta, andlongitudeDeltavia thesetInitialValuemethodTesting
Run the
exampleapps to confirm functionality.