Feature: GeoJSON Marker Title Prop & A bit Refactor#3965
Feature: GeoJSON Marker Title Prop & A bit Refactor#3965christopherdro merged 9 commits intoreact-native-maps:masterfrom
Conversation
|
@christopherdro, Actually I could not find the linter error. Can you help me to find it to pass from CI. |
|
@WrathChaos please update the docs and types for this new props. I’ll take a closer look at the error on CI |
|
@christopherdro, |
|
@WrathChaos Here as well please. https://github.com/react-native-maps/react-native-maps/blob/master/index.d.ts#L598-L611 |
|
@christopherdro Done :) |
christopherdro
force-pushed
the
Feature/GeoJSONTitle
branch
from
830b91b to
11d38a7
Compare
|
@WrathChaos I made a mistake while trying to fix the lint errors. Can you push force push your changes on branch |
kuraydev
force-pushed
the
Feature/GeoJSONTitle
branch
from
11d38a7 to
4e310e3
Compare
|
@christopherdro Done |
christopherdro
force-pushed
the
Feature/GeoJSONTitle
branch
from
4e310e3 to
eb91424
Compare
|
@christopherdro When do you think this and the other PR's will be on live? |
|
@WrathChaos Can't say for sure right now, but one option is to point to your fork and create a branch with whatever changes you want on top of the latest stable release. |
…s#3965) * new: PropType is added for title prop * new: PropType is added for title prop * new: tappable prop has the PropType description * fix: tappable crash is fixed * fix: Better description for title prop * new: GeoJSON doc is updated * new: types are added for geojson on index.t.ts * Fix lint * cleanup Co-authored-by: Christopher Dro <hello@blick-labs.com>
2 participants
Does any other open PR do the same thing?
No other PR has the same thing
What issue is this PR fixing?
No issue right there, directly a fix and a new feature.
How did you test this PR?
Tested on both iOS and Android with both simulators and real devices.
What to do
New Feature
GeoJSONhas the new prop option:titlewhich shows a defaultCalloutwith the title.