fix: add ref support for Web#376
Merged
Naturalclar merged 2 commits intoreact-native-picker:masterfrom Mar 1, 2022
Merged
Conversation
|
@Naturalclar gentle bump to review this when you get the time, thanks so much! Fixes issue #375 |
Naturalclar
approved these changes
Feb 21, 2022
Contributor
Naturalclar
left a comment
Naturalclar
left a comment
There was a problem hiding this comment.
@LucioChavezFuentes thanks for the fix!
Contributor
|
@LucioChavezFuentes CI seems to be failing could you do me a favor and run the linter on lines you edited? |
7 tasks
Contributor
Author
|
@Naturalclar I fixed the lint errors. You can review it again. |
Contributor
Author
|
And thank you for your time to review. |
Naturalclar
approved these changes
Mar 1, 2022
Contributor
Naturalclar
left a comment
Naturalclar
left a comment
There was a problem hiding this comment.
@LucioChavezFuentes thanks 👍
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
## [2.3.1](v2.3.0...v2.3.1) (2022-03-01) ### Bug Fixes * add ref support for Web ([#376](#376)) ([c7e4180](c7e4180))
Contributor
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
Thank you @Naturalclar, I really appreciate your time on review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes on
forwardedRefallows anyone to pass a Reactrefon Web version and get a ref of<select>tag that rendersPicker. I am currently using a forked version with these changes in order to getfocus( )method of<select>tag and avoid dirty code.Let me know guys what do you think. I am fully available to make any changes neccesary.