This repository was archived by the owner on Feb 8, 2020. It is now read-only.
fix: don't call getNode if ref is already scrollable#162
Merged
satya164 merged 1 commit intoreact-navigation:masterfrom Nov 8, 2019
Merged
fix: don't call getNode if ref is already scrollable#162satya164 merged 1 commit intoreact-navigation:masterfrom
satya164 merged 1 commit intoreact-navigation:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 36 36
Lines 758 758
Branches 192 200 +8
=======================================
Hits 707 707
Misses 42 42
Partials 9 9Continue to review full report at Codecov.
|
satya164
approved these changes
Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facebook/react-native@66e72bb deprecates
getNodesince Animated components now useReact.forwardRef. To avoid triggering the warning I added a check to see if the node is already a scrollable node before trying to call the various method to get the scrollable node. This avoids calling getNode in newer RN versions.