Skip to content

docs: Maintain code editor tab position when changing tabs#1395

Merged
ntucker merged 1 commit intomasterfrom
docs/stabilize-code-tab
Oct 16, 2021
Merged

docs: Maintain code editor tab position when changing tabs#1395
ntucker merged 1 commit intomasterfrom
docs/stabilize-code-tab

Conversation

@ntucker
Copy link
Collaborator

@ntucker ntucker commented Oct 16, 2021

Motivation

When users change tabs it can change the amount of content on the page, this means the existing scroll position might move the element they are clicking on.

Solution

Using the infrastructure from facebook/docusaurus#5618

@ntucker ntucker requested a review from ljharb October 16, 2021 19:24
@codecov-commenter
Copy link

Codecov Report

Merging #1395 (afeff6e) into master (aabff9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1395   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          92       92           
  Lines        1728     1728           
  Branches      345      345           
=======================================
  Hits         1704     1704           
  Misses          5        5           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabff9e...afeff6e. Read the comment docs.

@ntucker ntucker merged commit 2ac471d into master Oct 16, 2021
@ntucker ntucker deleted the docs/stabilize-code-tab branch October 16, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants