Skip to content

Update Spelling and Update Packages for tests with CVE #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisPulman merged 1 commit into from
Nov 6, 2024
Merged

Update Spelling and Update Packages for tests with CVE #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public string Name
}
```

Before these Source Generators were avaliable we used ReactiveUI.Fody.
Before these Source Generators were available we used ReactiveUI.Fody.
With ReactiveUI.Fody the `[Reactive]` Attribute was placed on a Public Property with Auto get / set properties, the generated code from the Source Generator and the Injected code using Fody are very similar with the exception of the Attributes.

```csharp
Expand Down
8 changes: 4 additions & 4 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
<ItemGroup>
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.6.146" />
<PackageVersion Include="NuGet.Common" Version="6.11.1" />
<PackageVersion Include="NuGet.Protocol" Version="6.11.1" />
<PackageVersion Include="stylecop.analyzers" Version="1.2.0-beta.556" />
<PackageVersion Include="Roslynator.Analyzers" Version="4.12.9" />
<PackageVersion Include="ReactiveUI" Version="20.1.63" />
Expand All @@ -19,18 +21,16 @@
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="$(CodeAnalysisVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="$(CodeAnalysisVersion)" />
<PackageVersion Include="PolySharp" Version="1.14.1" />

<PackageVersion Include="Avalonia" Version="11.1.4" />
<PackageVersion Include="Avalonia.Themes.Fluent" Version="11.1.4" />
<PackageVersion Include="Avalonia.Fonts.Inter" Version="11.1.4" />
<PackageVersion Include="Avalonia.ReactiveUI" Version="11.1.4" />
<PackageVersion Include="Avalonia.Diagnostics" Version="11.1.4" />
<PackageVersion Include="Avalonia.Desktop" Version="11.1.4" />

<PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="8.0.1" />
<PackageVersion Include="ReactiveUI.Maui" Version="20.1.63" />

<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageVersion Include="System.Formats.Asn1" Version="8.0.1" />
<PackageVersion Include="xunit" Version="2.9.2" />
<PackageVersion Include="xunit.runner.console" Version="2.9.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
Expand All @@ -45,4 +45,4 @@
<PackageVersion Include="Basic.Reference.Assemblies.Net80" Version="1.7.9" />
<PackageVersion Include="Basic.Reference.Assemblies.Net80Windows" Version="1.7.9" />
</ItemGroup>
</Project>
</Project>
3 changes: 3 additions & 0 deletions src/ReactiveUI.SourceGenerator.Tests/ReactiveUI.SourceGenerators.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
<ItemGroup>
<PackageReference Include="coverlet.msbuild" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="NuGet.Common" />
<PackageReference Include="NuGet.Protocol" />
<PackageReference Include="System.Formats.Asn1" />
<PackageReference Include="xunit" />
<PackageReference Include="xunit.runner.visualstudio" />
<PackageReference Include="ReactiveMarbles.SourceGenerator.TestNuGetHelper" />
Expand Down
2 changes: 1 addition & 1 deletion src/ReactiveUI.SourceGenerators/Reactive/Models/PropertyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ internal sealed record PropertyInfo(
string FieldName,
string PropertyName,
string? Initializer, // TODO: Remove Initializer when ObservableAsPropertyHelper is updated
bool IsReferenceTypeOrUnconstraindTypeParameter,
bool IsReferenceTypeOrUnconstrainedTypeParameter,
bool IncludeMemberNotNullOnSetAccessor,
EquatableArray<string> ForwardedAttributes,
string AccessModifier);