docs: translate Extracting State Logic into a Reducer #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaddeuscleo
changed the title
mazipan
reviewed
May 8, 2023
mazipan
reviewed
May 8, 2023
…github.com/thaddeuscleo/id.react.dev into docs/extracting-state-logic-into-a-reducer
resir014
requested changes
May 10, 2023
mhaidarhanif
previously requested changes
May 10, 2023
Collaborator
mhaidarhanif
left a comment
mhaidarhanif
left a comment
There was a problem hiding this comment.
Need some changes.
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Member
|
Hi @thaddeuscleo, has the requested changes been made? |
r17x
approved these changes
Jun 26, 2023
Member
|
Taking over this PR since it's been weeks without any additional response. |
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
resir014
approved these changes
Jun 29, 2023
mazipan
reviewed
Jun 29, 2023
resir014
changed the title
resir014
reviewed
Jul 12, 2023
Member
resir014
left a comment
resir014
left a comment
There was a problem hiding this comment.
Some more requested changes to use the correct form of "di-" @thaddeuscleo
Member
|
@thaddeuscleo Could you make the requested changes within the next 2 days? If not, the maintainers can take over this PR. |
resir014
reviewed
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #383