feat(ExecJSRenderer) add ExecJSRenderer#299
Merged
rmosolgo merged 3 commits intoreactjs:masterfrom Jun 19, 2015
rmosolgo:execjs-renderer
Merged
feat(ExecJSRenderer) add ExecJSRenderer#299rmosolgo merged 3 commits intoreactjs:masterfrom rmosolgo:execjs-renderer
rmosolgo merged 3 commits intoreactjs:masterfrom
rmosolgo:execjs-renderer
Conversation
Member
Author
|
no news is good news |
rmosolgo
pushed a commit
that referenced
this pull request
Jun 19, 2015
feat(ExecJSRenderer) add ExecJSRenderer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
ExecJSRendererwas created while testing server rendering performance and I thought it might be a chance to reorganize server rendering code. In this branch:ExecJSRendereris basically a wrapper around ExecJSSprocketsRendereris anExecJSRendererwhich fetches source JS from the asset pipeline & enables "console replay"What do you think?
Pros:
#before_renderand#after_renderhooks add extensibility as requested in Decouple renderer #253 (comment)react-rails, maybe people will make their ownCons:
renderToStringandrenderToStaticMarkup? Right now, that's very awkward.react-railsdepends on sprockets, why wouldn't you useSprocketsRenderer?Anyways, curious what others think of this change!