Skip to content

Config & initialization fixes#302

Merged
rmosolgo merged 4 commits intoreactjs:masterfrom
rmosolgo:transformer-fixes
Jun 30, 2015
Merged

Config & initialization fixes#302
rmosolgo merged 4 commits intoreactjs:masterfrom
rmosolgo:transformer-fixes

Conversation

@rmosolgo
Copy link
Copy Markdown
Member

  • Accept transformer class from config
    • Right now the only way to do that was assign React::JSX.transformer_class = which is ok with me, but I guess a Rails config is more normal
  • Don't reload the transformer in dev
    • Make development match production
    • If you change your JSX config, you'll need to restart the app anyways
  • Move JSXTransformerTest
    • one class, one file: works nice with Guard, makes it easy to find the tests for a class
    • (I know not all of react-rails is on that pattern yet but i'm working on it :)
  • fix(ServerRendering) default pool_size of 1; document deadlock & ther…
  • refactor(AssetVariant) extract asset build & path logic
    • just want to DRY it up and get logic out of the Railtie

@danott
Copy link
Copy Markdown
Contributor

danott commented Jun 24, 2015

Great work! 💯

rmosolgo pushed a commit that referenced this pull request Jun 30, 2015
@rmosolgo rmosolgo merged commit 259e299 into reactjs:master Jun 30, 2015
@rmosolgo rmosolgo deleted the transformer-fixes branch June 30, 2015 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants