Update thinking-in-react.md to filter products in FilterableProductTable#95
Closed
danielsbird wants to merge 1 commit intoreactjs:masterfrom
Closed
Update thinking-in-react.md to filter products in FilterableProductTable#95danielsbird wants to merge 1 commit intoreactjs:masterfrom
danielsbird wants to merge 1 commit intoreactjs:masterfrom
Conversation
|
Deploy preview ready! Built with commit 1abb1cc |
bvaughn
reviewed
Oct 9, 2017
| ## Step 4: Identify Where Your State Should Live | ||
|
|
||
| <p data-height="600" data-theme-id="0" data-slug-hash="qPrNQZ" data-default-tab="js" data-user="lacker" data-embed-version="2" class="codepen">See the Pen <a href="https://codepen.io/gaearon/pen/qPrNQZ">Thinking In React: Step 4</a> on <a href="http://codepen.io">CodePen</a>.</p> | ||
| <p data-height="600" data-theme-id="0" data-slug-hash="QqgJjK" data-default-tab="js" data-user="danielsbird" data-embed-version="2" class="codepen">See the Pen <a href="https://codepen.io/danielsbird/pen/QqgJjK/">Thinking In React: Step 4</a> on <a href="https://codepen.io">CodePen</a>.</p> |
Contributor
There was a problem hiding this comment.
cc @gaearon It would probably be nice (for future maintainability) to link to a Codepen that someone on the React team can maintain.
| ## Step 5: Add Inverse Data Flow | ||
|
|
||
| <p data-height="600" data-theme-id="0" data-slug-hash="LzWZvb" data-default-tab="js,result" data-user="rohan10" data-embed-version="2" data-pen-title="Thinking In React: Step 5" class="codepen">See the Pen <a href="https://codepen.io/gaearon/pen/LzWZvb">Thinking In React: Step 5</a> on <a href="http://codepen.io">CodePen</a>.</p> | ||
| <p data-height="600" data-theme-id="0" data-slug-hash="QqgJNG" data-default-tab="js,result" data-user="danielsbird" data-embed-version="2" data-pen-title="Thinking In React: Step 5" class="codepen">See the Pen <a href="https://codepen.io/danielsbird/pen/QqgJNG/">Thinking In React: Step 5</a> on <a href="https://codepen.io">CodePen</a>.</p> |
Contributor
|
Hi @danielsbird 😄 Sorry this PR got stranded. As of PR #245, we're now able to directly link to code examples stored right here in this project's git repository. I plan to eventually migrate all Codepen examples here (see #246) but I'll also welcome your help if you're interested. All that to say this: I'm going to close this PR, but I'll be happy to review a new one that embeds the updated code directly. This way it's easy for the core team (and others) to update in the future. |
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
* add react without es6 pt-br translation * Apply suggestions from code review to fix Portuguese typos Co-Authored-By: gutofoletto <gutofoletto@gmail.com> * changed wikipedia link to point to Portuguese website Co-Authored-By: gutofoletto <gutofoletto@gmail.com> * Apply suggestions from Portuguese review Co-Authored-By: gutofoletto <gutofoletto@gmail.com> * changed the word 'estado' to 'state' Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Thinking in React by moving responsibility for filtering products from the
ProductTablecomponent to its parent component,FilterableProductTable.I think having
FilterableProductTablebe responsible for filtering the products improves the example for two reasons:ProductTableto be used outside ofFilterableProductTableI originally created an issue and a PR in the facebook/react repo but then the documentation was moved to this repo.