Skip to content

Conversation

@koustov
Copy link
Member

@koustov koustov commented Nov 26, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Changed the path resolution mechanism

Fixes #18

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@koustov koustov requested a review from atapas as a code owner November 26, 2022 08:29
@atapas atapas merged commit 6404760 into main Nov 26, 2022
@atapas atapas deleted the Issue-18-global-packge-not-working-on-mac-and-ubuntu branch November 26, 2022 08:31
@Angra974 Angra974 mentioned this pull request Sep 24, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: The npx create-react-play doesn't work on Mac

3 participants