-
-
Notifications
You must be signed in to change notification settings - Fork 934
Closed
Labels
✨ goal: improvementImprovement to an existing featureImprovement to an existing feature🏁 status: ready for devReady for workReady for work💻 aspect: codeConcerns the software code in the repositoryConcerns the software code in the repository🛠 goal: refactorneed to refactor codebaseneed to refactor codebase🟨 priority: mediumNot blocking but should be fixed soonNot blocking but should be fixed soon
Description
File Name
https://github.com/reactplay/react-play/blob/main/src/common/header/HeaderNav.jsx#L127
Reason for Refactoring the Code
we need to refactor the navbar's social icons links using .map method
<li>
<Link
className="app-header-btn app-header-btn--default"
data-testid="leaderboard-btn"
title="Leader Board"
to="/leaderboard"
>
<BsTrophyFill className="icon idea-icon" />
<span className="btn-label">Leader Board</span>
</Link>
</li>
<li>
<Link
className="app-header-btn app-header-btn--default"
data-testid="ideas-btn"
title="Play Ideas"
to="/ideas"
>
<FaLightbulb className="icon idea-icon" />
<span className="btn-label">Idea</span>
</Link>
</li>
<li>
<a
className="app-header-btn app-header-btn--default"
data-testid="github-btn"
data-umami-event="github-button"
href="https://github.com/reactplay/react-play"
rel="noopener noreferrer"
target="_blank"
title="GitHub page"
>
<BsGithub className="icon github-icon" />
<span className="btn-label">GitHub</span>
</a>
</li>
<li>
<a
className="app-header-btn app-header-btn--default"
data-testid="twitter-btn"
href="https://twitter.com/reactplayio"
rel="noopener noreferrer"
target="_blank"
title="Twitter Page"
>
<FaXTwitter className="icon twitter-icon" />
<span className="btn-label">Twitter</span>
</a>
</li>
<li>
<button
className="app-header-btn app-header-btn--default"
data-testid="share-btn"
title="Show love"
onClick={handleClick}
>
<IoHeartSharp className="icon share-icon" />
<span className="btn-label">Share</span>
</button>
</li>
Record
- I have checked the existing issues
- I have read the Contributing Guidelines
- I agree to follow this project's Code of Conduct
- I want to work on this issue
Metadata
Metadata
Assignees
Labels
✨ goal: improvementImprovement to an existing featureImprovement to an existing feature🏁 status: ready for devReady for workReady for work💻 aspect: codeConcerns the software code in the repositoryConcerns the software code in the repository🛠 goal: refactorneed to refactor codebaseneed to refactor codebase🟨 priority: mediumNot blocking but should be fixed soonNot blocking but should be fixed soon