Bugs fix/cypress/1251 #1254
Merged
Bugs fix/cypress/1251 #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for reactplayio failed.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
4 tasks
priyankarpal
approved these changes
Oct 1, 2023
priyankarpal
added
review ready
hacktoberfest
hacktoberfest-accepted
Member
|
Hi @Angra974 can you please merge the latest changes from main? |
joshi-kaushal
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cypress test fails because it tests twitter tweets but the tweets were replaced by the testimonial.
On localhost, sometimes contributors test fails too.
Sometimes tests fail just because of the timeout is too short
Fixes #1251
Type of change
Replace the current tests by new one for homepage.
Add minimum test for leaderboard and ideas.
Add a longer timeout to cypress config
Please delete options that are not relevant.
How Has This Been Tested?
Use it another branch where tests are done before push
Run locally with cypress:run too
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
run cypress:run
Checklist:
Screenshots or example output