Skip to content

Conversation

@koustov
Copy link
Member

@koustov koustov commented May 3, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Closes #29

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 3, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

@koustov koustov marked this pull request as draft May 3, 2022 17:51
@vercel
Copy link

vercel bot commented May 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 6, 2022 at 11:06AM (UTC)

@koustov
Copy link
Member Author

koustov commented May 5, 2022

@atapas the PR looks good now.

@koustov koustov marked this pull request as ready for review May 5, 2022 14:35
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment I have about this change

image

Why is it needed?

@koustov
Copy link
Member Author

koustov commented May 6, 2022

Only comment I have about this change

image

Why is it needed?

Unwanted check-in. Removed now

@atapas
Copy link
Member

atapas commented May 6, 2022

@koustov Should we add some text in the create play md that you can now create a play using both typescript and javascript.. kind of highlighting it?

@koustov
Copy link
Member Author

koustov commented May 6, 2022

@koustov Should we add some text in the create play md that you can now create a play using both typescript and javascript.. kind of highlighting it?

That would be nice I will get it added

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@atapas atapas merged commit 7659efa into reactplay:main May 7, 2022
@atapas
Copy link
Member

atapas commented May 7, 2022

@all-contributors please add @koustov for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @koustov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Add TypeScript Support

2 participants