Skip to content

Conversation

@chhakuli123
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

After auth play was not getting liked because in nhost intializating it requires subdomain and region.

Fixes # (issue)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@netlify
Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 875ac84
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65c9ae9d4f632100080844ee
😎 Deploy Preview https://deploy-preview-1417--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@chhakuli123
Copy link
Contributor Author

Hi @priyankarpal
How can I see live preview of this PR
image

@priyankarpal
Copy link
Member

Hi @priyankarpal How can I see live preview of this PR image

now you can check. We(maintainers) have to accept the deployment after you can see the deployed site.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an error please check
image

@priyankarpal priyankarpal added the changes required need to change some thing label Dec 31, 2023
@priyankarpal priyankarpal added ready to merge and removed changes required need to change some thing labels Feb 9, 2024
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@chhakuli123
Copy link
Contributor Author

Looks Good 🎉

Is feature working after auth?

@priyankarpal
Copy link
Member

Looks Good 🎉

Is feature working after auth?

yes

@joshi-kaushal joshi-kaushal merged commit fe95c29 into reactplay:main Feb 12, 2024
@priyankarpal
Copy link
Member

@all-contributors please add @chhakuli123 for code

@allcontributors
Copy link
Contributor

@priyankarpal

I've put up a pull request to add @chhakuli123! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants