Skip to content

Conversation

@Deepak8717
Copy link
Member

@Deepak8717 Deepak8717 commented May 16, 2022

Description

Registration form with validation without any third party

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented May 16, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

@atapas
Copy link
Member

atapas commented May 16, 2022

@Deepak8717 You need to add a clear description when u create the PR of link the issue to it to get started.

@atapas atapas linked an issue May 16, 2022 that may be closed by this pull request
@vercel
Copy link

vercel bot commented May 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 16, 2022 at 0:58AM (UTC)

@atapas
Copy link
Member

atapas commented May 16, 2022

@Deepak8717 Can you show the submitted details on submit(with password as ****? That makes the play more complete.. as in someone filled the registration, submitted and see the result. Alternatively, a message with the name saying it has been submitted successful, etc,

@atapas atapas self-requested a review May 16, 2022 13:07
{
id: "pl-registration-form",
name: "Registration-Form",
description: "Registration form with form validation without any liberary",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library spelling mistake

@@ -0,0 +1,13 @@
# registration-form

A Simple registration form with validation without any libery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library spelling mistake

{/* Your Code Starts Here */}
<div className="registration-form-container">
<h1>Registration Form</h1>
<p>A Simple registration form with validation without any libery</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library spelling mistake

<>
<div className="play-details">
<PlayHeader play={play} />
<div className="play-details-body">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please do the similar changes I have suggested here?

#131 (comment)

});
//function checks for all validation
const isValidated = (field) => {
if (field.name.trim() === "") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire logic can be shorten with function and switch-case?

@atapas atapas added the work in progress The work is in progress label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress The work is in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Registration Page form validation

2 participants