Skip to content

Conversation

@Deepak8717
Copy link
Member

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

A Registration form validation without any library

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 19, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

@atapas
Copy link
Member

atapas commented May 20, 2022

@Deepak8717 Is it ready for review?

@atapas atapas self-requested a review May 20, 2022 05:51
@Deepak8717
Copy link
Member Author

Yes @atapas , I have gone through the code review guideline and comments on previous pull request. Please review

@vercel
Copy link

vercel bot commented May 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 24, 2022 at 6:22AM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deepak8717 Comments....

@Deepak8717
Copy link
Member Author

Deepak8717 commented May 21, 2022

Thanks @atapas , These are great suggestion. There is always a room for improving. there is a lot more i could do like code enhancement, feature enhancement eg specific password/name format. show/hide error on input focus. I am always willing to push the limit but this project has really tested my js skills that i just wanted to finish to take a break and work on my other portfolio projects. May be return back after a week and raise new issues and enhance further.

tldr; improving everything in at one time difficult, may be take break and comeback with refresh mind always helps

@atapas
Copy link
Member

atapas commented May 23, 2022

Thanks @atapas , These are great suggestion. There is always a room for improving. there is a lot more i could do like code enhancement, feature enhancement eg specific password/name format. show/hide error on input focus. I am always willing to push the limit but this project has really tested my js skills that i just wanted to finish to take a break and work on my other portfolio projects. May be return back after a week and raise new issues and enhance further.

tldr; improving everything in at one time difficult, may be take break and comeback with refresh mind always helps

I am fine as long as you keep improving :)

Kindly resolve the merge conflicts.. lets get this in.

Btw, I have seen that both the files have conflicts have been modified beyond the scope by you. Hence you got conflicts. You may want to check that out.

@Deepak8717

@Deepak8717
Copy link
Member Author

@atapas merge resolved. Please check and accept the changes for time being

@atapas atapas merged commit f52be30 into reactplay:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants