-
-
Notifications
You must be signed in to change notification settings - Fork 934
Registration form validation without any library #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixed conflicts
|
Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel. @atapas first needs to authorize it. |
|
@Deepak8717 Is it ready for review? |
|
Yes @atapas , I have gone through the code review guideline and comments on previous pull request. Please review |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
atapas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Deepak8717 Comments....
|
Thanks @atapas , These are great suggestion. There is always a room for improving. there is a lot more i could do like code enhancement, feature enhancement eg specific password/name format. show/hide error on input focus. I am always willing to push the limit but this project has really tested my js skills that i just wanted to finish to take a break and work on my other portfolio projects. May be return back after a week and raise new issues and enhance further. tldr; improving everything in at one time difficult, may be take break and comeback with refresh mind always helps |
I am fine as long as you keep improving :) Kindly resolve the merge conflicts.. lets get this in. Btw, I have seen that both the files have conflicts have been modified beyond the scope by you. Hence you got conflicts. You may want to check that out. |
|
@atapas merge resolved. Please check and accept the changes for time being |
Description
A Registration form validation without any library
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: