Skip to content

Conversation

@Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented May 23, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

I worked on adding the XML sitemap file and its reference to the robots.txt file. fixed minor SEO issues too.

Fixes #212

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 23, 2022 at 4:00PM (UTC)

@Sachin-chaurasiya
Copy link
Member Author

Review Ready

Copy link
Collaborator

@erayalkis erayalkis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thank you for your contribution!

@erayalkis erayalkis merged commit a4de431 into reactplay:main May 23, 2022
@atapas
Copy link
Member

atapas commented May 24, 2022

@all-contributors please add @Sachin-chaurasiya for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @Sachin-chaurasiya! 🎉

@Sachin-chaurasiya Sachin-chaurasiya deleted the issue-212 branch May 24, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: XML Sitemap is not linked in robots.txt file and other SEO issues

3 participants