Skip to content

Conversation

@Deepak8717
Copy link
Member

@Deepak8717 Deepak8717 commented May 25, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

A new projects to learn about dynamic routes
a beginner friendly app where you put the meal category in the url and based on the input app shows the relevant recipes.

closes #234

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

have manually tested each and every functionality along with warnings and errors.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented May 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 27, 2022 at 9:44AM (UTC)

@atapas
Copy link
Member

atapas commented May 26, 2022

@Deepak8717 Create an issue explaining what is the objective.

@atapas
Copy link
Member

atapas commented May 26, 2022

@Deepak8717 Is it review ready?

@Deepak8717
Copy link
Member Author

@atapas yes

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the initial state it is not easy to understand what is selected.

image

@Deepak8717
Copy link
Member Author

@atapas Please check. I have added the images, fixed the responsiveness, fixed initial menu selection bug and updated readme file.

@atapas
Copy link
Member

atapas commented May 27, 2022

@Deepak8717 A small one

image

@Deepak8717
Copy link
Member Author

@atapas done

@Deepak8717
Copy link
Member Author

@atapas done

@Deepak8717
Copy link
Member Author

@atapas fixed it

@atapas atapas merged commit 6e2e208 into reactplay:main May 27, 2022
@Deepak8717 Deepak8717 deleted the new/dynamic-routes branch May 27, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Play : Dynamic Routes

2 participants