Skip to content

Conversation

@MOHAMED-EHAB-DEV
Copy link
Contributor

@MOHAMED-EHAB-DEV MOHAMED-EHAB-DEV commented May 30, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@netlify
Copy link

netlify bot commented May 30, 2022

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 3c5a561
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6294b943eb4c56000894836d
😎 Deploy Preview https://deploy-preview-246--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MOHAMED-EHAB-DEV
Copy link
Contributor Author

@atapas

@MOHAMED-EHAB-DEV
Copy link
Contributor Author

Please begin to review

@MOHAMED-EHAB-DEV MOHAMED-EHAB-DEV changed the title #200 issue ✨ [Feature request]: If a play doesn't have a blog, link it to the Readme May 30, 2022
@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jun 2, 2022 at 0:41AM (UTC)

@MOHAMED-EHAB-DEV
Copy link
Contributor Author

@atapas Do you want to any another changes ?

@MOHAMED-EHAB-DEV
Copy link
Contributor Author

Hey

@MOHAMED-EHAB-DEV
Copy link
Contributor Author

@atapas Done

please review

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@atapas atapas merged commit d92c14d into reactplay:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: If a play doesn't have a blog, link it to the Readme

2 participants