Skip to content

Conversation

@ankitk26
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Creation date for any play was added to the PlayHeader component. The date-fns library was used to get the locale-aware format of the date.

Fixes #862

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Different locale formats were added manually to check the right format of the date.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

@vercel
Copy link

vercel bot commented Feb 12, 2023

@ankitk26 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ❌ Failed (Inspect) Feb 26, 2023 at 7:44AM (UTC)

@atapas
Copy link
Member

atapas commented Feb 12, 2023

@ankitk26 The build fails

image

@ankitk26
Copy link
Contributor Author

I will push the changes after fixing the error soon

@atapas
Copy link
Member

atapas commented Feb 13, 2023

@koustov Can you please review this one?

@atapas
Copy link
Member

atapas commented Feb 13, 2023

The build still fails

image

Please fix the lint errors and run the yarn build locally.

@ankitk26
Copy link
Contributor Author

ankitk26 commented Feb 13, 2023

Hi @atapas, I ran the yarn build command and it created the build folder without any errors.
image

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/63eaf819830c642a23d0685e

@atapas
Copy link
Member

atapas commented Feb 21, 2023

@ankitk26 Finally it got built.

A small comment on it. I see the vertical alignment of the dot, and the date is a bit off. Can you please fix that for merge?

image

@atapas atapas merged commit 3d6e54d into reactplay:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Show the Play creation date in the play page

3 participants