-
-
Notifications
You must be signed in to change notification settings - Fork 934
Creation date added to Play header #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ankitk26 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ankitk26 The build fails |
|
I will push the changes after fixing the error soon |
|
@koustov Can you please review this one? |
|
Hi @atapas, I ran the yarn build command and it created the build folder without any errors. |
❌ Deploy Preview for reactplayio failed.
|
|
@ankitk26 Finally it got built. A small comment on it. I see the vertical alignment of the dot, and the date is a bit off. Can you please fix that for merge? |




Description
Creation date for any play was added to the PlayHeader component. The date-fns library was used to get the locale-aware format of the date.
Fixes #862
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Different locale formats were added manually to check the right format of the date.
Checklist:
Screenshots or example output