Skip to content

EXP-15601: Updated error log to include NSError for S7IniConfig#88

Merged
kvoskovskiy merged 1 commit intomainfrom
task/EXP-15601-git-config-issue
Sep 9, 2025
Merged

EXP-15601: Updated error log to include NSError for S7IniConfig#88
kvoskovskiy merged 1 commit intomainfrom
task/EXP-15601-git-config-issue

Conversation

@kvoskovskiy
Copy link
Contributor

Ticket link

EXP-15575

PR description

  • What is the context for this PR?

Updated S7IniConfig.m + (instancetype)configWithContentsOfFile:(NSString *)filePath implementation to include NSError form initWithContentsOfFile error property or keep "Failed to read string content" error message if we read no content without any error.

  • Why did you take the approach you did?

Screenshot / Videos

If it would be useful, please, include screenshots, animated GIFs or screencasts of changes in action

PR submission checklist

  • PR name contains Jira ticket number
  • PR have correct target branch
  • .s7substat has correct subrepos revisions
  • Common (Obj-C / Swift) and your team's coding conventions and style guidelines are followed
  • Unit tests to cover the critical parts of the code are written
  • Relevant documentation updated / added if needed
  • Self-reviewed using the self-review checklist prior to submitting a PR
  • All recommendations from the How to create Pull Request document are followed

Copy link
Contributor

@pastey pastey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kvoskovskiy kvoskovskiy merged commit 2b4dd41 into main Sep 9, 2025
3 checks passed
@kvoskovskiy kvoskovskiy deleted the task/EXP-15601-git-config-issue branch September 9, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants