feat(cli): adding a new --identifier option for supplying an SDK identifier
#675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
erunion
requested review from
a team,
Dashron,
darrenyong and
domharrington
and removed request for
a team
domharrington
approved these changes
Jul 17, 2023
Member
domharrington
left a comment
domharrington
left a comment
There was a problem hiding this comment.
LGTM! Could we prefill the identifier from slug(info.api.title) (or something else?) if they dont provide one? Could we also not prompt them if we detect they're in an environment where we can't accept user input (like CI, or automated installer)?
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This adds a new optional
--identifieroption to the CLI interface for presetting the identifier you want to use with your generated SDK.🧬 QA & Testing
This CLI has no unit tests at the moment so I just tested this out manually; notice I was not prompted to enter in an identifier.
And my
debugSDK was installed into.api/apisand will be able to be used as@api/debug: