feat: drop support for node 16 and move to require native fetch #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
approved these changes
Sep 12, 2023
Contributor
kanadgupta
left a comment
kanadgupta
left a comment
There was a problem hiding this comment.
some cleanup below but otherwise LGTM! i think we should hold off on tagging a release until we do some more QoL work
erunion
commented
Sep 12, 2023
kanadgupta
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Now that Node 16 is hitting its end of life today1 we can stop supporting it and move completely over to Node 18+'s native
fetch.apiandhttpsnippet-client-apifully over to expecting thatfetchis available -- no more polyfills with isomorphic-fetch.fixes RM-7988
Footnotes
https://endoflife.date/nodejs ↩