feat: deprecating the dynamic api entrypoint
#723
Conversation
| expect(`${code}\n`).toStrictEqual(expected); | ||
| }); | ||
|
|
||
| it('should generate a functional snippet', async () => { |
There was a problem hiding this comment.
These tests used a dist of the dynamic api entrypoint. I don't really have any interest in trying to get this extremely gross (my fault) vm sandboxing work working on that so I'm deleting all this. In the future it would probably be worth fleshing out a full integration suite for all these test cases but that's all really pertinent to api and not code snippet generation.
There was a problem hiding this comment.
would be cool to have some sort of mocking framework/library for easily testing these plugins
kanadgupta
left a comment
kanadgupta
left a comment
There was a problem hiding this comment.
you'll be missed, proxy variant 🫡
| "main": "./dist/index.js", | ||
| "types": "./dist/index.d.ts", |
| expect(`${code}\n`).toStrictEqual(expected); | ||
| }); | ||
|
|
||
| it('should generate a functional snippet', async () => { |
There was a problem hiding this comment.
would be cool to have some sort of mocking framework/library for easily testing these plugins
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
🧰 Changes
The dynamic, Proxy-based, variant of
apihas been really holding us back so this is the formal deprecation and removal of all code relating to it. It was a neat experimental hack that I am very proud of but it's time to move on to only supporting codegen here as all that work, and the TS type backings it offers, are far superior.Rest in peace little buddy.
fixes RM-7986