Skip to content

refactor(api): cleaning up the api directory now that core is split out #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erunion merged 1 commit into from
Sep 14, 2023
Merged

refactor(api): cleaning up the api directory now that core is split out #728

erunion merged 1 commit into from
Sep 14, 2023

Conversation

@erunion
Copy link
Member

@erunion erunion commented Sep 14, 2023

🧰 Changes

Now that @api/core exists the main api package is only CLI things so it doesn't make sense for its source to exist in src/cli anymore.

@erunion erunion added the refactor Issues about tackling technical debt label Sep 14, 2023
@erunion erunion requested a review from kanadgupta September 14, 2023 23:04
@erunion erunion marked this pull request as ready for review September 14, 2023 23:04
@erunion erunion merged commit ef4e95c into main Sep 14, 2023
@erunion erunion deleted the feat/directory-cleanup branch September 14, 2023 23:12
@erunion erunion added this to the v7 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kanadgupta kanadgupta kanadgupta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor Issues about tackling technical debt

Projects

None yet

Milestone

v7

Development

Successfully merging this pull request may close these issues.

3 participants

@erunion @kanadgupta