Skip to content

refactor: remove make-dir as a dep #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erunion merged 2 commits into from
Oct 6, 2023
Merged

refactor: remove make-dir as a dep #746

erunion merged 2 commits into from
Oct 6, 2023

Conversation

@kanadgupta
Copy link
Contributor

@kanadgupta kanadgupta commented Sep 28, 2023 •
edited by erunion
Loading

🧰 Changes

make-dir isn't needed a we can call fs.makeDirSync instead.

@erunion erunion marked this pull request as ready for review October 6, 2023 17:31
@erunion erunion added the refactor Issues about tackling technical debt label Oct 6, 2023
@erunion erunion merged commit ab41a72 into main Oct 6, 2023
@erunion erunion deleted the kanad/rm-8049-remove-make-dir-dependency branch October 6, 2023 17:32
@kanadgupta
Copy link
Contributor Author

kanadgupta commented Oct 6, 2023 •
edited
Loading

@erunion the fs return value is slightly different from make-dir’s (I think one includes the full path and one is only the directory name itself) and it’s not tested so we might need to do a bit of additional validation here 🫠

@erunion erunion mentioned this pull request Oct 6, 2023
Merged
@erunion erunion added this to the v7 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erunion erunion erunion approved these changes

Assignees

No one assigned

Labels

refactor Issues about tackling technical debt

Projects

None yet

Milestone

v7

Development

Successfully merging this pull request may close these issues.

3 participants

@kanadgupta @erunion