Skip to content

Conversation

@kanadgupta
Copy link
Contributor

@kanadgupta kanadgupta commented Sep 29, 2023

🚥 Resolves ISSUE_ID

🧰 Changes

Spike on using tshy for the build — seems more strictly typed than tsup (see this tweet from a TS maintainer)

TODO

  • Look into using ESNext / bundler in tsconfig for core subpackage (based on my reading, I think the moduleResolution is the one that needs extra revisiting)

Current blockers:

  • Figure out how to properly load in the spec file — currently we're in a catch-22 where the JSON import isn't being properly asserted and then import assertions aren't supported in CJS
  • @readme/api-core isn't a module (we really gotta merge in feat: migrate api and core to ESM #733)

🧬 QA & Testing

Provide as much information as you can on how to test what you've done.

@kanadgupta kanadgupta closed this Oct 6, 2023
@kanadgupta kanadgupta deleted the esm-tshy branch October 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants