feat(api): codegen'd sdks now look a little bit nicer #769
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -380,7 +380,6 @@ class SDK { | |
| } | ||
| } | ||
|
|
||
| const createSDK = (() => { return new SDK(); })(); | ||
|
|
||
| export default createSDK; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,92 @@ | ||
| import RuleSource from './RuleSource'; | ||
|
|
||
| const AmqpExternalRulePatch = { | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "requestMode": { | ||
| "description": "Single request mode sends each event separately to the endpoint specified by the rule. You can read more about single request mode events in the <a href=\"https://ably.com/documentation/general/events#batching\">Ably documentation</a>.", | ||
| "enum": [ | ||
| "single" | ||
| ], | ||
| "type": "string", | ||
| "examples": [ | ||
| "single" | ||
| ] | ||
| }, | ||
| "ruleType": { | ||
| "description": "The type of rule. In this case AMQP external (using Firehose). See the <a href=\"https://ably.com/documentation/general/firehose\">Ably documentation</a> for further information.", | ||
| "enum": [ | ||
| "amqp/external" | ||
| ], | ||
| "type": "string" | ||
| }, | ||
| "source": RuleSource, | ||
| "status": { | ||
| "description": "The status of the rule. Rules can be enabled or disabled.", | ||
| "enum": [ | ||
| "enabled", | ||
| "disabled" | ||
| ], | ||
| "type": "string", | ||
| "examples": [ | ||
| "enabled" | ||
| ] | ||
| }, | ||
| "target": { | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "enveloped": { | ||
| "description": "Messages delivered through Reactor are wrapped in an Ably envelope by default that contains metadata about the message and its payload. The form of the envelope depends on whether it is part of a Webhook/Function or a Queue/Firehose rule. For everything besides Webhooks, you can ensure you only get the raw payload by unchecking \"Enveloped\" when setting up the rule.", | ||
| "type": [ | ||
| "boolean", | ||
| "null" | ||
| ] | ||
| }, | ||
| "format": { | ||
| "type": "string" | ||
| }, | ||
| "headers": { | ||
| "description": "If you have additional information to send, you'll need to include the relevant headers.", | ||
| "items": { | ||
| "properties": { | ||
| "name": { | ||
| "description": "The name of the header.", | ||
| "type": "string" | ||
| }, | ||
| "value": { | ||
| "description": "The value of the header.", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "type": "object" | ||
| }, | ||
| "type": "array" | ||
| }, | ||
| "mandatoryRoute": { | ||
| "description": "Reject delivery of the message if the route does not exist, otherwise fail silently.", | ||
| "type": "boolean" | ||
| }, | ||
| "messageTtl": { | ||
| "description": "You can optionally override the default TTL on a queue and specify a TTL in minutes for messages to be persisted. It is unusual to change the default TTL, so if this field is left empty, the default TTL for the queue will be used.", | ||
| "type": "integer" | ||
| }, | ||
| "persistentMessages": { | ||
| "description": "Marks the message as persistent, instructing the broker to write it to disk if it is in a durable queue.", | ||
| "type": "boolean" | ||
| }, | ||
| "routingKey": { | ||
| "description": "The AMQP routing key. See this <a href=\"https://knowledge.ably.com/what-is-the-format-of-the-routingkey-for-an-amqp-or-kinesis-reactor-rule\">Ably knowledge base article</a> for details.", | ||
| "type": "string" | ||
| }, | ||
| "url": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "type": "object", | ||
| "title": "amqp_external_rule_patch", | ||
| "x-readme-ref-name": "amqp_external_rule_patch" | ||
| } as const; | ||
| export default AmqpExternalRulePatch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,93 @@ | ||
| import RuleSource from './RuleSource'; | ||
|
|
||
| const AmqpExternalRulePost = { | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "requestMode": { | ||
| "description": "Single request mode sends each event separately to the endpoint specified by the rule. You can read more about single request mode events in the <a href=\"https://ably.com/documentation/general/events#batching\">Ably documentation</a>.", | ||
| "enum": [ | ||
| "single" | ||
| ], | ||
| "type": "string", | ||
| "examples": [ | ||
| "single" | ||
| ] | ||
| }, | ||
| "ruleType": { | ||
| "description": "The type of rule. In this case AMQP external (using Firehose). See the <a href=\"https://ably.com/documentation/general/firehose\">documentation</a> for further information.", | ||
| "enum": [ | ||
| "amqp/external" | ||
| ], | ||
| "type": "string" | ||
| }, | ||
| "source": RuleSource, | ||
| "target": { | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "enveloped": { | ||
| "description": "Messages delivered through Reactor are wrapped in an Ably envelope by default that contains metadata about the message and its payload. The form of the envelope depends on whether it is part of a Webhook/Function or a Queue/Firehose rule. For everything besides Webhooks, you can ensure you only get the raw payload by unchecking \"Enveloped\" when setting up the rule.", | ||
| "type": [ | ||
| "boolean", | ||
| "null" | ||
| ] | ||
| }, | ||
| "format": { | ||
| "type": "string" | ||
| }, | ||
| "headers": { | ||
| "description": "If you have additional information to send, you'll need to include the relevant headers.", | ||
| "items": { | ||
| "properties": { | ||
| "name": { | ||
| "description": "The name of the header.", | ||
| "type": "string" | ||
| }, | ||
| "value": { | ||
| "description": "The value of the header.", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "type": "object" | ||
| }, | ||
| "type": "array" | ||
| }, | ||
| "mandatoryRoute": { | ||
| "description": "Reject delivery of the message if the route does not exist, otherwise fail silently.", | ||
| "type": "boolean" | ||
| }, | ||
| "messageTtl": { | ||
| "description": "You can optionally override the default TTL on a queue and specify a TTL in minutes for messages to be persisted. It is unusual to change the default TTL, so if this field is left empty, the default TTL for the queue will be used.", | ||
| "type": "integer" | ||
| }, | ||
| "persistentMessages": { | ||
| "description": "Marks the message as persistent, instructing the broker to write it to disk if it is in a durable queue.", | ||
| "type": "boolean" | ||
| }, | ||
| "routingKey": { | ||
| "description": "The AMQP routing key. See this <a href=\"https://knowledge.ably.com/what-is-the-format-of-the-routingkey-for-an-amqp-or-kinesis-reactor-rule\">Ably knowledge base article</a> for details.", | ||
| "type": "string" | ||
| }, | ||
| "url": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "url", | ||
| "routingKey", | ||
| "mandatoryRoute", | ||
| "persistentMessages" | ||
| ], | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "ruleType", | ||
| "requestMode", | ||
| "source", | ||
| "target" | ||
| ], | ||
| "type": "object", | ||
| "title": "amqp_external_rule_post", | ||
| "x-readme-ref-name": "amqp_external_rule_post" | ||
| } as const; | ||
| export default AmqpExternalRulePost |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, TIL! kinda curious about the performance of this vs prettier vs others (but don't think we need to investigate that any time soon)