fix(api): run npm install with --ignore-scripts

[erunion]

🧰 Changes

The prepare script that was added to codegen'd package.json files in #761 is being executed when we install that SDK resulting us in running the compilation step twice. Because I'd like to keep the dependency installation and SDK dist compilation processes separate we should run npm install with the --ignore-scripts option.

fixes RM-8243

[kanadgupta]

so i added a little prompt after this line to confirm that the dist/ directory wasn't being built before the compilation step, but it looks like it's being built:

i did a little digging and was able to fix this by making this change on this line:

-    return execa('npm', [...npmInstall, installDir].filter(Boolean))
+    return execa('npm', [...npmInstall].filter(Boolean), { cwd: installDir })

[erunion]

Is the api in that case added to the root package.json file? I think thats just going to run npm i install the api and not add it as a dependency

[kanadgupta]

I think thats just going to run npm i install the api and not add it as a dependency

ah shit you're right 😬 my hunch is that the --ignore-scripts flag only applies to scripts in the package.json where you're running npm i from and it runs all the lifecycle scripts in the subdirectory's package.json

[kanadgupta]

another idea:

1. build the initial package.json without a prepare script
2. add the prepare script during the compilation step using npm pkg set?

[erunion]

might be nice to write a small wrapper for execa() that handles these success and failure states instead of having to copy-paste this code everywhere but i don't really have the energy at the moment to try to figure out how to clone all of execa's parameter typing into a wrapper

[kanadgupta]

i was able to confirm it works as expected with the fix below!

[kanadgupta]

great refactor here 🫶🏽