Skip to content

Conversation

@kanadgupta
Copy link
Contributor

@kanadgupta kanadgupta commented Oct 31, 2023

Turns out all those typing issues we were seeing earlier was just a stupid mirage so we can once again hide FromSchema in our core exports! (reverts #787)

Confirmed that attw is happy:

CleanShot 2023-10-31 at 13 53 40@2x

Tagging RM-8230 for posterity

@kanadgupta kanadgupta added enhancement New feature or request area:core Issues related to `core`, which is the package that powers the SDKs at runtime area:api Issues related to the `api` CLI, which builds the SDKs labels Oct 31, 2023
@kanadgupta kanadgupta marked this pull request as ready for review October 31, 2023 18:53
@kanadgupta kanadgupta requested a review from erunion October 31, 2023 18:54
@kanadgupta kanadgupta merged commit f7679f4 into main Oct 31, 2023
@kanadgupta kanadgupta deleted the revert-787-fix/typing-issues branch October 31, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:api Issues related to the `api` CLI, which builds the SDKs area:core Issues related to `core`, which is the package that powers the SDKs at runtime enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants