feat: convert SDK output to module #802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Quick overview of what this PR does:
"type": "module"field to thepackage.jsonfile in the codgen'd SDKsexportsentrypoints in the codegen'd SDKs accordingly.jsfile extensions to all of the relative file imports in the codegen'd TS filesI opened this PR in hopes of fixing the typing issues in RM-8230 (which I later determined were an issue with my test environment and not with these SDKs)... but I still think our codegen'd SDKs should incorporate these changes! Here's why:
.jsconvention for relative file imports feels safer and more future-proof, even iftsupis proactively handling that for us--experimental-detect-moduleflag that has arrived in Node v21, we should be specifying the package.jsontypevalue anyways and it feels dated to specifycommonjsthere🧬 QA & Testing
Do tests still pass?