feat(api): import schemas in the types file as types #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
kanadgupta
approved these changes
Nov 8, 2023
Contributor
kanadgupta
left a comment
kanadgupta
left a comment
There was a problem hiding this comment.
this appears to be a fine change according to my testing but
i don't think i understand why... technically speaking, aren't the schemas in schemas.ts actually JSON schema objects as consts?
Member
Author
|
they are but they're used in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Because all of the schemas that we're importing in codegen'd
types.tsfiles are for types only we can import them explicitly as types.