test: run tsc on SDK fixtures
#819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is already present in `@tsconfig/node18/tsconfig.json`
kanadgupta
commented
Nov 8, 2023
| "declaration": true, | ||
| "declarationMap": true, | ||
| "sourceMap": true, | ||
| "strict": true, |
Contributor
Author
There was a problem hiding this comment.
this is already present in @tsconfig/node18/tsconfig.json so I removed it!
kanadgupta
added
enhancement
erunion
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
I've done cursory checks in the past to make sure our generated SDKs meet the requirements of TS strict mode, but it just occurred to me that we're not doing any type-checking in our tests, so this PR enables that. Glad to report that the SDKs passed with flying colors ✨
🧬 QA & Testing
Do tests still pass?