Skip to content

Conversation

@kanadgupta
Copy link
Contributor

@kanadgupta kanadgupta commented Apr 2, 2024

🧰 Changes

ts-node has been a janky pain in the ass with modern Node.js + ESM1, so this PR swaps it out for the far more stable tsimp2.

This shouldn't have any affect on end users — this is really just a change to our development / build process to get everything working again (though not entirely sure what changed in #872 that broke everything).

🧬 QA & Testing

Do tests pass?

Footnotes

  1. see https://github.com/TypeStrong/ts-node/issues/1997

  2. made by our boi isaac 😌

@kanadgupta kanadgupta added bug Something isn't working refactor Issues about tackling technical debt labels Apr 2, 2024
@kanadgupta kanadgupta requested a review from erunion April 2, 2024 00:17
@kanadgupta kanadgupta marked this pull request as ready for review April 2, 2024 00:17
@kanadgupta kanadgupta changed the title fix: swap out ts-node for tsimp fix: swap out ts-node for tsimp Apr 2, 2024
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sick

@kanadgupta kanadgupta merged commit 429fcf9 into main Apr 2, 2024
@kanadgupta kanadgupta deleted the kanad-2024-04-01/swap-out-ts-node-for-tsimp branch April 2, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working refactor Issues about tackling technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants